-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't show icons in Chrome on Windows #1
Comments
It seems to be broken on Opera too (12.11) |
Sorry to edit down the issue. Pushed a fix for the stray console.log (mea culpa). Not entirely sure what is causing the icons to break on Chrom and Opera on Windows, but will look into it. |
Just to chime in that I also have this issue. Chrome 23.0.1271.64, Windows 7. http://i.imgur.com/VDO9a.png |
Looks like it's due to a Chrome bug: http://code.google.com/p/chromium/issues/detail?id=122465 Should be an easy fix. |
It'll be anything but an easy fix. We've been waiting for that bug to get squashed for a long time now, and it's not happening. Whether it's OTS or another component, don't rely on that bug to ever be fixed. The easiest fix is probably to make the custom font not use PUA but instead use glyphs in the latin block or the likes. As long as the OS/2-table classification values are set correctly, this won't cause any problems. |
Well, there seems to be a reasonable workaround for the issue (implemented in Mozilla's PDF.js): mozilla/pdf.js@033545c I've just pushed this fix, which will hopefully resolve the issue. I've also updated the Font Custom website with a fixed set of fonts & CSS, if anyone would like to confirm. |
that hack didn't actually make us very happy, I'd strong recommend against using it in your own code. |
(Whoops, didn't realize you were a Moz dev :) What was the problem with it? It's ugly, but so is stuffing glyphs into the latin block. |
@endtwist it's not reasonable, on scale from 1 to 10, this fix is 0. pdf.js team made this fix because chrome team is not planning to fix that soon |
Well, this fix is the best I've got. Other patches welcome. |
putting the glyphs into the latin block, provided the font indicates it's not a "letter" font but a symbo font, is fairly acceptable practice. However, since PUA starts at U+E000, and the Chrome bug doesn't kick in until 0xF020, you could see what happens if you make your generate use the very start of the PUA area. a little over 4000 glyphs should be sufficient for symbol fonts, at least the ones your library generates? (That said, I didn't run a rigid test case to see whether there are any segments between E000 and F020 that are problematic, too) |
No description provided. |
I'm looking at http://fontcustom.com in Chrome (latest stable) on windows and none of the font icons actually show up.
The text was updated successfully, but these errors were encountered: