Streamline build process and fix incompatible masters #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Crimson Pro doesn’t build against the latest version of
fontTools
and thus impossible to contribute further changes. After fighting with the confusing error messages offontTools
for a few days, I finally figured out the release-blocking issues in the repository.Here’s the to-do list breakdown and my current progress:
removing large binaries from repo ✅
Proofs are still accessible through Git history. Font files could be uploaded through “Releases”.
change interpolation weight of semibold to 500⚠️ (needinfo)
Required by
fonttools
to have a “base master” instance that isn’t interpolated, see varLib.models locations parameter - how does it work? fonttools/fonttools#1943.To elaborate: The current “Regular” master has a weight of
500
, but none of the instances have this weight value; the closest would be Semibold, which has an interpolation weight of509
. This breaks a lot of assumptions from Google Fonts’ own toolchain, including floating-point rounding errors.fix incompatible masters on currency glyphs 🔜 (WIP)
There seems to be some unfinished alternative glyphs that is breaking the build.
I’ve successfully fixed all of them on my experimental fork (scaled 114% to match other fonts’ em-height), and I’ll produce a version on the vanilla Crimson Pro in the next few days:
update readme and build instructions
There are still a few glitches that I’m working on (e.g.
colonsign
breaks interpolation), but I’m gonna start a pull request first to keep track of the progress. Please let me know if there are any questions!