Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade minSdk to 23 #48

Merged
merged 5 commits into from
Oct 8, 2023
Merged

Downgrade minSdk to 23 #48

merged 5 commits into from
Oct 8, 2023

Conversation

FooIbar
Copy link
Owner

@FooIbar FooIbar commented Oct 8, 2023

Archives are currently not supported on API < 28.
Fallback image decoder may have low performance.

@FooIbar FooIbar enabled auto-merge (squash) October 8, 2023 09:48
@FooIbar FooIbar merged commit 9fa3ddd into 1.8.x.x Oct 8, 2023
2 checks passed
@FooIbar FooIbar deleted the fb/marshmallow branch October 8, 2023 10:04
@asuka-mio
Copy link
Collaborator

minsdk should never lower than 26 aka Oreo since
Bitmap are stored in dalvik heap on these platforms

@asuka-mio
Copy link
Collaborator

Doing so is meaningless unless you'd like infinity OOM
I suggest using hippo's

@asuka-mio
Copy link
Collaborator

@asuka-mio
Copy link
Collaborator

And that's why hippo use a external 'image' object and render it through OpenGL
We want bitmap data stored (at least...) in native heap

@FooIbar
Copy link
Owner Author

FooIbar commented Oct 9, 2023

My phone was broken and had to use an old phone (API 25) temporarily, it's not intended to bring full support to 23.
Surprisingly I didn't get much OOM with that 2G RAM device.

@FooIbar
Copy link
Owner Author

FooIbar commented Oct 9, 2023

mem
It doesn't look like it's going to OOM, except when loading GIFs.
mem_gif
Maybe I just remove GIF support completely.

@asuka-mio
Copy link
Collaborator

@FooIbar
Copy link
Owner Author

FooIbar commented Oct 15, 2023

libarchive/libarchive#1966

More related to #54
It somewhat helps, but does not solve the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants