Skip to content
This repository has been archived by the owner on Dec 31, 2023. It is now read-only.

Use new hook for delete #153

Merged
merged 1 commit into from
Apr 9, 2020
Merged

Use new hook for delete #153

merged 1 commit into from
Apr 9, 2020

Conversation

c-okelly
Copy link
Contributor

@c-okelly c-okelly commented Apr 8, 2020

In reference to issue #146

Also added the deleteMediaFile when dealing with urls.

The new functionality of writeData means that is there is a name conflict it will rename the file. This way the behavior of your api does not change.

Only potential issues I see with this is that the file is trashed but not deleted. So is only cleared up on the usual clear up.

Test locally using my own Anki install at 2.1.22 and POST man to create new media

In reference to issue FooSoft#146 

Also added the `deleteMediaFile` when dealing with urls. 

The new functionality of `writeData` means that is there is a name conflict it will rename the file. This way the behavior of your api does not change.

Only potential issues I see with this is that the file is `trashed` but not deleted. So is only cleared up on the usual clear up.

Test locally using my own Anki install at `2.1.22` and POST man to create new media
@FooSoft FooSoft merged commit 0bba096 into FooSoft:master Apr 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants