Skip to content
This repository has been archived by the owner on Dec 31, 2023. It is now read-only.

Update note #380

Merged
merged 2 commits into from
Apr 1, 2023
Merged

Update note #380

merged 2 commits into from
Apr 1, 2023

Conversation

Aquafina-water-bottle
Copy link
Contributor

@Aquafina-water-bottle Aquafina-water-bottle commented Mar 31, 2023 •
edited

It's been a while since the author of #370 did anything, and I'm interested in using these actions at some point in the future. This PR is simply #370 without merge conflicts. All credits go to @introt for the new features.

P.S. Echoing #378, is there a release plan for Anki-Connect to AnkiWeb? It's been a little while since the last update to the AnkiWeb version, and I would also like to use some of the recent changes at some point. Thanks in advance!

introt and others added 2 commits December 30, 2022 13:13
@introt
Add getNoteTags, updateNoteTags and updateNote
2f50c74 
getNoteTags returns [str ...] of tags for a given note (note: int)

updateNoteTags removes the existing tags and sets new tags

updateNote combines the old updateNoteFields and the new updateNoteTags

Closes FooSoft#369
@Aquafina-water-bottle
merged with master
ed508ba
@Aquafina-water-bottle Aquafina-water-bottle marked this pull request as draft March 31, 2023 06:55
@Aquafina-water-bottle Aquafina-water-bottle marked this pull request as ready for review March 31, 2023 07:03
@FooSoft
Copy link
Owner

FooSoft commented Apr 1, 2023

Looks good, thanks!

@FooSoft FooSoft merged commit 3c98885 into FooSoft:master Apr 1, 2023
@introt
Copy link
Contributor

introt commented Apr 3, 2023

Thanks @Aquafina-water-bottle !

@schlauchBot
Copy link

I don't know if that would work for your use case @Aquafina-water-bottle, but if you don't want to wait for the changes to appear on AnkiWeb, just replace the contents of your local Anki2/addons21/2055492159 with this repo's plugins/ folder content.
At least it worked for me to get this PR's changes.

@Aquafina-water-bottle
Copy link
Contributor Author

Aquafina-water-bottle commented Apr 8, 2023 •
edited

@schlauchBot Thanks for the tip! I'm using the master branch version with link.sh already, so I do indeed have the latest changes. The concern is primarily for other people who may want to use programs that require the latest features (I think the guys behind mpvacious wants to use the getMediaDirPath call for example). It would be a hassle to get their users to download a custom version of AnkiConnect just to use that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Aquafina-water-bottle @FooSoft @introt @schlauchBot