Skip to content
This repository has been archived by the owner on Feb 25, 2023. It is now read-only.

Dictionary validate updates #2137

Merged

Conversation

toasted-nutbread
Copy link
Collaborator

This change makes dictionary-validate.js and schema-validate.js able to use https://ajv.js.org as a validator for testing.

This was originally mentioned in #2129 (comment):

I don't know anything about JSON schema validation, and I haven't looked into how Yomichan does it or what engine it uses. My naive hope was that maybe Yomichan could be updated to use a faster validator (ajv claims to be the fastest) and perhaps that would be enough to solve the problem.

@toasted-nutbread toasted-nutbread merged commit 5a72303 into FooSoft:master May 17, 2022
@stephenmk
Copy link
Contributor

My new JMdict dictionary for Yomichan validates in 3.25 seconds on my PC now -- incredible!

@toasted-nutbread
Copy link
Collaborator Author

Yeah, it's because their validator compiles to actual JavaScript code, which presents some potential challenges with integrating into Yomichan. This is a first step towards evaluating what can be done here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants