Add support for filtering frequency metadata based on readings #450
Conversation
|
Is the term metadata going to be imported into the database even if you switch |
|
Yeah, that is the intent. There is no conversion since the data is already validated by the schema and is in the expected format. |
|
Ok, I was wondering if the DB schema had to be updated but seems that it supports storing objects as well. |
| @@ -562,6 +564,18 @@ class Translator { | |||
| return tagMetaList; | |||
| } | |||
|
|
|||
| getFrequencyData(expression, data, dictionary, term) { | |||
| if (data !== null && typeof data === 'object') { | |||
There was a problem hiding this comment.
Could use isObject as well
There was a problem hiding this comment.
This one I think is fine to leave as-is; the Array.isArray check is not necessary for this case since it should have been validated during import. Additionally, even if somehow the value was an array, it won't be any more wrong than having an incorrectly formatted object.
Yeah, it's not an indexed property currently, but even indexes should be able to store any type of data:
|
Resolves #382. Data format is as described in #382 (comment).