Skip to content
This repository has been archived by the owner on Sep 19, 2020. It is now read-only.

Report the file that failed to parse on parsing errors #746

Merged
merged 1 commit into from Apr 11, 2018
Merged

Conversation

tas50
Copy link
Contributor

@tas50 tas50 commented Apr 4, 2018

Right now if you provide a repo with a file that can't be parsed we just
fail, leaving you to figure out what file was bad. With this change we
rescue and report the failure.

Signed-off-by: Tim Smith tsmith@chef.io

Right now if you provide a repo with a file that can't be parsed we just
fail, leaving you to figure out what file was bad. With this change we
rescue and report the failure.

Signed-off-by: Tim Smith <tsmith@chef.io>
Copy link
Contributor

@robbkidd robbkidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Only question I have is whether there may be a more specific exception type to catch here. If not, looks good.

@tas50 tas50 merged commit 6741384 into master Apr 11, 2018
@tas50 tas50 deleted the fail_right branch May 3, 2018 18:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants