-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/tests #224
Merged
Merged
Feat/tests #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed test result status to "passed" with no failed tests. Refactored navigation test for internal links, ensuring correct redirections.
Added a new test to ensure external links in the navbar have correct href attributes. The test checks each external navigation item for the expected href value.
Added tests to check presence and correctness of FeatureComponent elements as well as the visibility of Rive animation on the page. Logging messages were included throughout the test process.
Added a data-testid attribute to the RiveComponent in FeatureComponent for testing purposes. Updated test results to show failed status with specific failed test ID. Improved comments and readability in tests.
Changed the status in the test results from "failed" to "passed" and removed a specific failed test ID. Updated the locator for the Rive animation component in the features test to use a data-testid attribute instead of a class.
Created a new test file to cover pricing module functionality.
Added data-testid attributes to PricingComponent elements for testing purposes, including pricing sections, plan buttons, and payment frequency options. Updated UI elements accordingly. Fixed failed test status in last run JSON file. Added new tests for pricing component interactions and Rive animation presence.
Changed the data-testid attribute in PricingComponent to use the billing cycle instead of ID. Updated test selectors accordingly.
Deleted a file storing failed test results. Updated pricing tests to wait for plan loading and improved selector handling for monthly and annual plans.
Created a new JSON file to store test results with status "passed" and no failed tests.
Created a new test file to cover CTA component testing.
Adjusted CTA component markup for better accessibility. Updated test results to show failed tests with IDs. Added Playwright tests for CTA section visibility and links functionality.
Changed test results to show "passed" status and updated CTA spec tests to use environment variables for base URL. Added checks for specific text content in the CTA section and links.
- Added "dotenv" package to dependencies - Updated test status to "failed" with failed test details - Refactored URL handling in tests for better clarity
Changed test results to show "passed" status and updated CTA spec to use regular expression for sign-in URL check.
Changed the logo alt attribute to include "logo ForVoyez", updated test status to "failed" with a specific failed test ID, and added a new sign-in test script.
Refactor sign-in button locators for better specificity and clarity.
Changed test result status to "passed" with no failed tests. Improved sign-in process by updating locators, adding log messages, and checking user profile details in the dialog.
Expanded the sign-in test to include checking and clicking the "Manage account" button, verifying redirection to the manage account page, and confirming the presence of the email address on that page.
Included a new script in package.json to run end-to-end tests with Playwright.
- Updated Playwright test version to 1.44.1 in package.json. - Improved sign-in process with additional checks and sign-out flow.
Created a new test file to cover functionality of the app dashboard component.
Added test IDs to dashboard links for testing. Updated test results to show failed status with specific failed tests. Implemented tests for dashboard quick links functionality, ensuring correct navigation and handling of different link types.
…ndling ResourceCardAppComponent now includes a data-testid attribute for testing purposes. The handling of quick links in the dashboard test has been updated to include testId properties for each link, improving element selection and navigation logic.
- Improved handling of quick links in the dashboard test - Reorganized code for better readability and efficiency
Simplified the check for product variants existence in a loop.
Simplify null check for variantDetails attributes.
Remove redundant user authentication checks in service functions to improve code readability and maintainability.
Removed an unused function and updated imports in the test file.
Removed redundant internal and external quick link tests. Streamlined test execution flow.
Refactored the test to create checkout URLs for authenticated users using new mock data and updated expectations. Added coverage for creating multiple checkouts with specific attributes.
Improved error handling during LemonSqueezy setup to handle and log errors effectively. Updated tests to ensure proper error management scenarios are covered.
Added error logging functionality to log an error if a variant ID is undefined during plan synchronization. Also, implemented a test case for proceeding without logging an error if the variant ID is defined.
Implemented syncing plans with Lemon Squeezy, updating product details and variants accordingly. Added tests for the sync functionality.
Added error handling and logging for various scenarios in the `syncPlans` function. This includes logging errors if variant ID is undefined, continuing execution if certain data is missing, checking for missing attributes, and throwing an error if an exception occurs during synchronization.
LightInn
approved these changes
Jun 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bon, je te propose d'achever cette mr record.... et je prie pour ne plus jamais en voir de tel 😢
Updated tests to handle cases where a user is not found or has missing credits. Added error messages for clarity and improved test coverage.
Added logic to update creditsLeft based on existing data and return hourlyUsageArray with specific conditions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lot's of things, fixes, improvments, and 90% of e2e tests