Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged toggle stylesheet #17

Closed
mkg20001 opened this issue Oct 6, 2019 · 3 comments · Fixed by #51
Closed

Merged toggle stylesheet #17

mkg20001 opened this issue Oct 6, 2019 · 3 comments · Fixed by #51
Milestone

Comments

@mkg20001
Copy link
Contributor

mkg20001 commented Oct 6, 2019

After #15 is merged, it should be considered if creating a merged toggle stylesheet with both light and dark themes might make sense

@Carl-Hugo
Copy link
Member

We could add that without much development, nor maintenance effort and it could be convenient to <link> only one stylesheet instead of two.

One pro from this addition would be when paired with a reusable toggle light/dark button. However, I'm not sure if this repository would be the best place for this feature as there could be multiple types of toggle button like plain JS, Angular Component, etc.

If we go that way, without that toggle button idea, we'd need a name for that file that is easy to understand.

What are your pros, cons, and use cases for this?

@mkg20001
Copy link
Contributor Author

mkg20001 commented Oct 7, 2019

Use case: Switching the theme without needing to include two files

Pros: It's just one file
Cons: It has both, you can't take "just dark" and add another external theme on top of that

We should keep the separate files and add the merged one as another file

@Carl-Hugo
Copy link
Member

As much as I understand, I'm wondering if it is worth the "effort" and the additional asset; including two files should be pretty easy.

That said, how would you name that new file? Quick brainstorming: toggle-all.css, toggle-all-themes.css, toggle-themes.css, etc.

@Carl-Hugo Carl-Hugo linked a pull request Jun 4, 2021 that will close this issue
4 tasks
@Carl-Hugo Carl-Hugo added this to the 1.2.0 milestone Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants