Combined dark/light CSS files without duplicated code #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-[x] default: light | prefers: light -[x] default: light | prefers: dark -[ ] default: dark | prefers: light -[x] default: dark | prefers: dark Bugs dark/light are caused by color variables being null in Bootstrap and overridden in Bootstrap-dark.
This was
linked to
issues
Jun 4, 2021
Closed
Closed
Not overriding $card-color fixes the toggling between light and dark. This reverts to Bootstrap default behaviors.
Carl-Hugo
deleted the
experiments/creating-my-own-plugin-to-remove-duplicates
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.2.0 (preview)
This is a prerelease version that could contain bugs.
bootstrap-dark-prefers-light.csswhich default to Bootstrap dark and display the light colors if the user'sprefers-color-scheme: light.bootstrap-light-prefers-dark.csswhich default to Bootstrap and display the dark colors if the user'sprefers-color-scheme: dark.bootstrap-prefers-dark-color-only.csswhich is only the colors ofbootstrap-prefers-dark.css. This is autogenerated byclean_non_color_attr.js.bootstrap-prefers-light-color-only.csswhich is only the colors ofbootstrap-prefers-light.css. This is autogenerated byclean_non_color_attr.js.clean_non_color_attr.jsgulp plugin (based ongulp-css-remove-attributes).Completed state
bootstrap-light-prefers-dark.css)bootstrap-light-prefers-dark.css)bootstrap-dark-prefers-light.css)bootstrap-dark-prefers-light.css)Known issues
nullin Bootstrap and overridden in Bootstrap-dark.