Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reboot classes included in both themes #49

Closed
prymitive opened this issue Apr 15, 2021 · 1 comment · Fixed by #51
Closed

Reboot classes included in both themes #49

prymitive opened this issue Apr 15, 2021 · 1 comment · Fixed by #51
Milestone

Comments

@prymitive
Copy link

When using bootstrap-dark reboot styles are included under .bootstrap {} (see https://github.com/ForEvolve/bootstrap-dark/blob/master/scss/toggle-bootstrap.scss#L20), the side effect is that they might be more specific then extra classes imported and so override them. An example is using FontAwesome icons that use .fa-xxx on svg elements for extra styling, those styles are overwritten by https://github.com/twbs/bootstrap/blob/v4.6.0/scss/_reboot.scss#L257-L262.

Would it be possible to move reboot from under .bootstrap {}?

@Carl-Hugo
Copy link
Member

It would be possible but will require some additional efforts to ensure both light and dark stylesheets are not creating conflicts as _reboot.scss is included in both. Moreover, at first glance, there seem to be some color variables involved in _reboot.scss, which may cause some conflicts. One example would be L52 and L54, and there are more.

That said, this could be fixed as part of some optimization related to #20 or #39, but my bandwidth is limited. I'll keep this in mind and hopefully find some time to move those items forward, including this one.

@Carl-Hugo Carl-Hugo linked a pull request Jun 4, 2021 that will close this issue
4 tasks
@Carl-Hugo Carl-Hugo added this to the 1.2.0 milestone Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants