Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap 5 supported #52

Closed
Nexucis opened this issue Nov 19, 2021 · 4 comments
Closed

Bootstrap 5 supported #52

Nexucis opened this issue Nov 19, 2021 · 4 comments

Comments

@Nexucis
Copy link

Nexucis commented Nov 19, 2021

Hi,

I'm wondering if you would like to support Bootstrap 5 in this repo or in another ?

Thanks for your work :).

@Carl-Hugo
Copy link
Member

I do not have any short-term plan for supporting Bootstrap 5 at the moment as there are just so many things I can do in a day.

@Nexucis Are you only using only the "dark theme" (a.k.a. Bootstrap but dark) or are you using the toggling between dark and light as well, see even the new experimental preferred color scheme feature?

@Nexucis
Copy link
Author

Nexucis commented Nov 22, 2021

thanks for your answer @Carl-Hugo :).
Yes I'm using a toggling between dark and light theme.
Thanks for the tips :). I will look at it !

@Carl-Hugo
Copy link
Member

Carl-Hugo commented Nov 22, 2021

I know of a project if you were only looking only for a dark theme @Nexucis, but that won't help you that much since you use toggling. Moreover, you'll probably need to update your HTML code to migrate from Bootstrap v4 to v5; I did not assess that workload yet, so it might be more trivial than it was from v3 to v4.

I just realized there are many experiments branches that I've tried to automate that process; the experimental branch I was referring to is experiments/creating-my-own-plugin-to-remove-duplicates.
One of the four scenarios does not work due to missing/empty color variables in Bootstrap; see 1.2.x (preview) Release notes for more info.
How it works is explained in the README as well.
EDIT: See also #51

That said, once that work is done, it should be reasonably easy to port it to v5, and Bootstrap v6 should support dark themes natively.

@Carl-Hugo
Copy link
Member

Closing this as I have no plan to support other versions of Bootstrap.

@Carl-Hugo Carl-Hugo closed this as not planned Won't fix, can't repro, duplicate, stale Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants