(#43) moved IsPrefixOf to IPath and added StartsWith to IPath #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also solved #28 |
ForNeVeR
requested changes
Jun 19, 2024
TruePath/AbsolutePath.cs
Outdated
| public bool IsPrefixOf(AbsolutePath other) | ||
| { | ||
| if (!(Value.Length <= other.Value.Length && other.Value.StartsWith(Value))) return false; | ||
| return other.Value.Length == Value.Length || other.Value[Value.Length] == Path.DirectorySeparatorChar; |
There was a problem hiding this comment.
I don't think other.Value[Value.Length] == Path.DirectorySeparatorChar is ever true for normalized paths (except for the bare root /), is it? So maybe let's drop that check?
ForNeVeR
force-pushed
the
absolutepath-startswith
branch
from
e5a97ab
to
2f1f3a3
Compare
This was referenced Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.