Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple delimiter support #28

Merged
merged 7 commits into from
Feb 20, 2017
Merged

Simple delimiter support #28

merged 7 commits into from
Feb 20, 2017

Conversation

ForNeVeR
Copy link
Owner

@ForNeVeR ForNeVeR commented Feb 19, 2017

I've added the support for some of the delimiter types mentioned in #14.

Fortunately, it turned out that the render already supports this feature. Here's the screenshot (check the big braces inside of the sum operator):
image

Remaining issues:

The implementation is yet very ad-hoc and maybe is missing very much important details; we'll need to determine and fix these later.

@ForNeVeR ForNeVeR self-assigned this Feb 19, 2017
@ForNeVeR ForNeVeR requested a review from gsomix February 19, 2017 09:26
@ForNeVeR ForNeVeR changed the title [WIP] Simple delimiter support Simple delimiter support Feb 19, 2017
Copy link
Collaborator

@gsomix gsomix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ForNeVeR ForNeVeR merged commit 074ce6b into master Feb 20, 2017
@ForNeVeR ForNeVeR deleted the feature/14-delimiters branch February 23, 2017 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants