Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoffeeScript compiler options don't get passed through #2

Closed
karthikv opened this issue Oct 20, 2012 · 4 comments
Closed

CoffeeScript compiler options don't get passed through #2

karthikv opened this issue Oct 20, 2012 · 4 comments

Comments

@karthikv
Copy link
Collaborator

The options parameter is never passed to the CoffeeScript compiler, as seen in index.js:204-216:

exports.coffee.render = function (str, options, fn) {
  if (typeof options.bare === 'undefined') {
      options.bare = true;
  }
  var engine = require.coffeescript || (require.coffeescript = require('coffee-script'));
  var res;
  try {
      res = engine.compile(str, {bare: false});
  } catch (ex) {
      return fn(ex);
  }
  fn(null, res);
};

{bare: false} needs to be changed to options.

@ForbesLindesay
Copy link
Member

I'll publish the fix once npm is working (it seems to be down at the moment)

@karthikv
Copy link
Collaborator Author

All right, let me know when it's published and I'll update Nodefront.

@ForbesLindesay
Copy link
Member

Version 1.0.0 has now been pushed with the fix.

@karthikv
Copy link
Collaborator Author

Great, thanks! It has been integrated into Nodefront.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants