Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Redis configuration file artifact #383

Merged
merged 4 commits into from Feb 20, 2020

Conversation

Onager
Copy link
Contributor

@Onager Onager commented Feb 18, 2020

No description provided.

@joachimmetz joachimmetz self-assigned this Feb 18, 2020
@joachimmetz joachimmetz self-requested a review February 18, 2020 05:45
- '%%environ_programfiles%%\Redis\conf\redis.windows.conf'
- '%%environ_programfiles%%\Redis\conf\redis.conf'
- '%%environ_programfiles%%/Redis/conf/redis.windows.conf'
- '%%environ_programfiles%%/Redis/conf/redis.conf'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use \ and add separator: \ to keep it closest to the OS path as possible

Copy link
Member

@joachimmetz joachimmetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor nits

@joachimmetz joachimmetz self-requested a review February 20, 2020 07:41
Copy link
Member

@joachimmetz joachimmetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joachimmetz joachimmetz merged commit ec43a1a into ForensicArtifacts:master Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants