Add depth_bias field to PolylineMaterial #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This let the user draw lines closer or further away from the camera than the line is really in the 3d world. A good use case for this is making the lines draw always in front of geometry, or slightly offsetting the line so they can be shown in front of geometry it shares with other things.
nicopap
commented
Apr 25, 2022
Also add some documentation explaining what it illustrates.
This commit accounts for homogenous clip space and makes sure the lines with a -1.0 depth_bias are always shown in front of everything else by having a depth value exactly equal to the clip's W. This uses an exponential function for user ergonomics. But honestly, we could probably do the exponential once on creating the material. and use linear calculation in the shader.
|
@aevyrie May I get your attention? You might have overlooked this PR. |
aevyrie
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This let the user draw lines closer or further away from the camera
than the line is really in the 3d world.
A good use case for this is making the lines draw always in front of
geometry, or slightly offsetting the line so they can be shown in front
of geometry it shares with other things.
Closes #25.
Note on
perspective: I would like to keep the ability to set/unset theperspectiveindependently from thedepth_bias. Perspective is a good way to see "where" a line should be even when it always show up in front of other things.