Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(serialiser): serialiser does not compute hidden smart fields anymore #1020

Merged
merged 3 commits into from
Nov 3, 2023
Merged

fix(serialiser): serialiser does not compute hidden smart fields anymore #1020

merged 3 commits into from
Nov 3, 2023

Conversation

SteveBunlon
Copy link
Member

@SteveBunlon SteveBunlon commented Nov 2, 2023 •
edited
Loading

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

Thenkei
Thenkei previously approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@Thenkei Thenkei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clever

@codeclimate CodeClimate
Copy link

codeclimate bot commented Nov 3, 2023

Code Climate has analyzed commit 479937a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (70% is the threshold).

This pull request will bring the total coverage in the repository to 61.9%.

View more on Code Climate.

@SteveBunlon
Copy link
Member Author

I have checked that the typings are correct on FES and FEM, which is the case already, no need to update them.

@SteveBunlon SteveBunlon closed this Nov 3, 2023
@SteveBunlon SteveBunlon reopened this Nov 3, 2023
@SteveBunlon SteveBunlon changed the title fix(serialiser): developers can now specify the fields they want to serialise fix(serialiser): developers can now specify the smart fields they want to serialise Nov 3, 2023
arnaudbesnier
arnaudbesnier approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@arnaudbesnier arnaudbesnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me.
The PR title is a bit misleading as the prefix is "fix" and the commit describes something as a new feature.

To me it is either a feature ("developers can now specify the fields they want to serialise") or a fix ("smart collections do not compute hidden fields/columns").

@SteveBunlon SteveBunlon changed the title fix(serialiser): developers can now specify the smart fields they want to serialise fix(serialiser): serialiser does not compute hidden smart fields anymore Nov 3, 2023
@SteveBunlon SteveBunlon merged commit 12bd547 into main Nov 3, 2023
9 checks passed
@SteveBunlon SteveBunlon deleted the fix/serializer-with-fields-options branch November 3, 2023 15:49
forest-bot added a commit that referenced this pull request Nov 3, 2023
@forest-bot
chore(release): 10.2.10 [skip ci]
0e3efdd 
## [10.2.10](v10.2.9...v10.2.10) (2023-11-03)

### Bug Fixes

* **serialiser:** serialiser does not compute hidden smart fields anymore ([#1020](#1020)) ([12bd547](12bd547))
@forest-bot
Copy link
Member

🎉 This PR is included in version 10.2.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaudbesnier arnaudbesnier arnaudbesnier approved these changes

@Thenkei Thenkei Thenkei left review comments

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SteveBunlon @forest-bot @arnaudbesnier @Thenkei