Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sequelize 4 returns date strings not timestamps so don't shift #123

Closed
wants to merge 1 commit into from
Closed

Sequelize 4 returns date strings not timestamps so don't shift #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
# Change Log

## [Unreleased]
### Fixes
- Records Serialization - Prevent DATEONLY fields being serialized to a daty behind in Sequelize 4 where UTC shift is negative

## RELEASE 1.5.2 - 2017-11-08
### Fixed
Expand Down
7 changes: 6 additions & 1 deletion serializers/resource.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,11 +107,16 @@ function ResourceSerializer(Implementation, model, records, integrator,
});
}

function isDateOnlyString(field) {
return moment(field, 'YYYY-MM-DD', true).isValid();
}

function formatFields(record) {
var offsetServer = moment().utcOffset() / 60;

_.each(fieldNamesDateonly, function (fieldName) {
if (record[fieldName]) {
//Sequelize 4 returns date strings while 3 returns dateTimeStrings
if (record[fieldName] && !isDateOnlyString(record[fieldName])) {
var dateonly = moment.utc(record[fieldName]).add(offsetServer, 'h');
record[fieldName] = dateonly.format();
}
Expand Down