Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(has many): fix link of has many #944

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Conversation

VincentMolinie
Copy link
Member

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

@forest-bot
Copy link
Member

Comment on lines +162 to +166
schema.fields.forEach((field) => {
if (!record[field.field] && _.isArray(field.type) && field.reference) {
record[field.field] = [];
}
});
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was done in the SmartFieldsValuesInjector but the thing is it has been changed to do it only for requested field (it was a side effect but it makes the has many work 😅 )

@VincentMolinie VincentMolinie merged commit c703c3f into 8.x.x Oct 11, 2022
@VincentMolinie VincentMolinie deleted the fix/has-many-link branch October 11, 2022 13:44
forest-bot added a commit that referenced this pull request Oct 11, 2022
## [8.7.7](v8.7.6...v8.7.7) (2022-10-11)

### Bug Fixes

* **has many:** fix link of has many ([#944](#944)) ([c703c3f](c703c3f))
@forest-bot
Copy link
Member

🎉 This PR is included in version 8.7.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants