Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release beta branch #956

Merged
merged 9 commits into from
Nov 8, 2022
Merged

chore: release beta branch #956

merged 9 commits into from
Nov 8, 2022

Conversation

VincentMolinie
Copy link
Member

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

Thenkei and others added 7 commits October 14, 2022 15:41
BREAKING CHANGE: drop support of projects that are not using roles

Co-authored-by: Guillaume Gautreau <guillaumeg@forestadmin.com>
# [10.0.0-beta.1](v9.5.6...v10.0.0-beta.1) (2022-10-14)

### Code Refactoring

* use new permissions mechanism v4 ([#943](#943)) ([ffcd051](ffcd051))

### BREAKING CHANGES

* drop support of projects that are not using roles

Co-authored-by: Guillaume Gautreau <guillaumeg@forestadmin.com>
# [10.0.0-beta.2](v10.0.0-beta.1...v10.0.0-beta.2) (2022-10-27)

### Bug Fixes

* **chart:** improve security on chart and rename keys ([#949](#949)) ([a45500f](a45500f))
# [10.0.0-beta.3](v10.0.0-beta.2...v10.0.0-beta.3) (2022-11-02)

### Features

* **chart:** add support for context variables used by Workspaces ([#952](#952)) ([07c2f94](07c2f94))
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 5806 lines exceeds the maximum allowed for the inline comments feature.

@VincentMolinie VincentMolinie changed the title chore: merge beta into main chore: release beta branch Nov 8, 2022
forest-bot and others added 2 commits November 8, 2022 09:58
# [10.0.0-beta.4](v10.0.0-beta.3...v10.0.0-beta.4) (2022-11-08)

### Features

* **chart:** add support for context variables inside SQL query ([#953](#953)) ([1d088ff](1d088ff))
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 5813 lines exceeds the maximum allowed for the inline comments feature.

@codeclimate
Copy link

codeclimate bot commented Nov 8, 2022

Code Climate has analyzed commit 4f8b7ee and detected 10 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1
Duplication 9

The test coverage on the diff in this pull request is 82.7% (70% is the threshold).

This pull request will bring the total coverage in the repository to 60.2% (-0.6% change).

View more on Code Climate.

@adriguy
Copy link
Contributor

adriguy commented Nov 8, 2022

The diff-coverage is not met (-0.6% change) especially because we removed some files that were 100% tested (and because we just indented some files that were not well tested).
And as this repo is not the one we want to invest a lot of time now, I'm forcing the merge here.

@adriguy adriguy merged commit 8e6bd6b into main Nov 8, 2022
@forest-bot
Copy link
Member

🎉 This PR is included in version 10.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants