Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(requires-approval): development environment should trigger without requiring an approval #971

Merged
merged 1 commit into from
Dec 28, 2022
Merged

fix(requires-approval): development environment should trigger without requiring an approval #971

merged 1 commit into from
Dec 28, 2022

Conversation

Thenkei
Copy link
Member

@Thenkei Thenkei commented Dec 28, 2022

…

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

@forest-bot
Copy link
Member

Task linked: CU-860pcb9dt 🔥🔥🔥 P1 - Conditional custom action - Cannot trigger an action in a development environment

@codeclimate
Copy link

codeclimate bot commented Dec 28, 2022

Code Climate has analyzed commit 2fde3fc and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (70% is the threshold).

This pull request will bring the total coverage in the repository to 61.4%.

View more on Code Climate.

@Thenkei Thenkei requested a review from ghusse December 28, 2022 15:32
@Thenkei Thenkei merged commit cd714d5 into main Dec 28, 2022
@Thenkei Thenkei deleted the fix/dev-requires-approval branch December 28, 2022 15:32
forest-bot added a commit that referenced this pull request Dec 28, 2022
@forest-bot
chore(release): 10.1.2 [skip ci]
4fae73e 
## [10.1.2](v10.1.1...v10.1.2) (2022-12-28)

### Bug Fixes

* **requires-approval:** development environment should trigger without requiring an approval ([#971](#971)) ([cd714d5](cd714d5))
@forest-bot
Copy link
Member

🎉 This PR is included in version 10.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghusse ghusse ghusse approved these changes

Assignees

@ghusse ghusse

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Thenkei @forest-bot @ghusse