Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(security): authorised only allowed stats queries using permissions #434

Merged
merged 12 commits into from
Mar 15, 2021

Conversation

Thenkei
Copy link
Member

@Thenkei Thenkei commented Mar 4, 2021

Pull Request checklist:

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Create automatic tests
  • No automatic tests failures
  • Test manually the implemented changes
  • Review my own code (indentation, syntax, style, simplicity, readability)
  • Wonder if you can improve the existing code

@forest-bot
Copy link
Member

Task linked: CU-f11utn Stats endpoints security

@codeclimate
Copy link

codeclimate bot commented Mar 11, 2021

Code Climate has analyzed commit 876d316 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2

The test coverage on the diff in this pull request is 85.7% (34% is the threshold).

This pull request will bring the total coverage in the repository to 35.4%.

View more on Code Climate.

@DrRaider DrRaider removed their assignment Mar 11, 2021
@Thenkei Thenkei changed the title feat(security): authorized only allowed live queries using permissions feat(security): authorised only allowed stats queries using permissions Mar 12, 2021
@Thenkei Thenkei merged commit 2014ab5 into master Mar 15, 2021
@Thenkei Thenkei deleted the feat/charts-live-queries-permissions branch March 15, 2021 16:17
forest-bot added a commit that referenced this pull request Mar 15, 2021
# [6.1.0](v6.0.5...v6.1.0) (2021-03-15)

### Features

* **security:** authorised only allowed stats queries using permissions ([#434](#434)) ([2014ab5](2014ab5))
@forest-bot
Copy link
Member

🎉 This PR is included in version 6.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Watanabe1011 added a commit to Watanabe1011/Forest-Rails that referenced this pull request Jun 3, 2024
# [6.1.0](ForestAdmin/forest-rails@v6.0.5...v6.1.0) (2021-03-15)

### Features

* **security:** authorised only allowed stats queries using permissions ([#434](ForestAdmin/forest-rails#434)) ([2014ab5](ForestAdmin/forest-rails@2014ab5))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants