[*] Command Generate - Fix foreign key imports using connection URL with MySQL #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentMolinie
requested changes
Oct 22, 2019
VincentMolinie
requested changes
Oct 24, 2019
VincentMolinie
approved these changes
Oct 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do not usually like PR that fixes two issues, but in this case, fixing one has revealed one other: I would have not seen the foreign key error without Sequelize replacements. So the two fix are relatives to each other. So basically:
field = '${foo}'as been replaced byfield = :foo+{ replacements: { foo } }dbName,connectionUrlis parsed for MySQL (which is the only one who requires its own database name when analyzing foreign keys).