Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server crash #2343

Closed
moran-x opened this issue Jan 19, 2019 · 3 comments
Closed

Server crash #2343

moran-x opened this issue Jan 19, 2019 · 3 comments

Comments

@moran-x
Copy link

moran-x commented Jan 19, 2019

Forestry version: 1.12.2-5.8.2.380
BuildCraft version: 7.99.20 to 7.99.21
Forge version: 1.12.2-14.23.5.2768
Link to crash report or log: https://pastebin.com/3SZT76gR
multiplayer: multiplayer
Steps to reproduce: Update buildcraft from 7.99.20 to 7.99.21
Additional information: ---
@AlexIIL
Copy link
Contributor

AlexIIL commented Jan 19, 2019

(Originally reported here: BuildCraft/BuildCraft#4326)

@AlexIIL
Copy link
Contributor

AlexIIL commented Jan 19, 2019

Sorry I should have looked before... but I changed buildcraft's API names from upper case BuildCraftAPI|transport to buildcraftapi_transport which breaks any @Optional() annotations on methods. (For example https://github.com/ForestryMC/ForestryMC/blob/mc-1.12/src/main/java/forestry/core/utils/InventoryUtil.java#L89).

AlexIIL added a commit to AlexIIL/ForestryMC that referenced this issue Jan 19, 2019
@AlexIIL
Fix updated buildcraft API name, fixing ForestryMC#2343.
852afa2 
Caused by the fix for BuildCraft/BuildCraftAPI#44 (where railcraft couldn't properly depend on the BC API's as forge rejected the old names).
@AlexIIL AlexIIL mentioned this issue Jan 19, 2019
Merged
@AlexIIL
Copy link
Contributor

AlexIIL commented Jan 19, 2019

(Sorry about this, I should have looked at #2340 before - as this is technically a duplicate of that one).

@AlexIIL AlexIIL mentioned this issue Jul 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AlexIIL @moran-x @Nedelosk