Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the Infuser to accept valid inputs #603

Closed
wants to merge 4 commits into from

Conversation

airbreather
Copy link
Contributor

This fixes #602.

In that issue, I mentioned some concern about some other things that started breaking. Most of it was expected behavior (didn't initially notice the item entities getting dropped when closing the inventory the first few times), and the rest was an inconsistency between the alyzers and both the imprinter and infuser.

CLAHub is giving me a generic "We're sorry, but something went wrong." page after I agree to the CLA. In case that's a problem, here's a message I signed with the same key I've been using to sign all my dinky little Minecraft mods since September 2013:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Silly as it may seem to me to do such a formal thing for such a small
change, I don't like friction, so here goes.  I release this to the
public domain, using this template I got from unlicense.org:

This is free and unencumbered software released into the public domain.

Anyone is free to copy, modify, publish, use, compile, sell, or
distribute this software, either in source code form or as a compiled
binary, for any purpose, commercial or non-commercial, and by any
means.

In jurisdictions that recognize copyright laws, the author or authors
of this software dedicate any and all copyright interest in the
software to the public domain. We make this dedication for the benefit
of the public at large and to the detriment of our heirs and
successors. We intend this dedication to be an overt act of
relinquishment in perpetuity of all present and future rights to this
software under copyright law.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
IN NO EVENT SHALL THE AUTHORS BE LIABLE FOR ANY CLAIM, DAMAGES OR
OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
OTHER DEALINGS IN THE SOFTWARE.

For more information, please refer to <http://unlicense.org>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (MingW32)

iQEcBAEBAgAGBQJVJddIAAoJEK1RwlgOR5zUxxcH/R6n5tgcEujdW0DiCBJ3I3Ed
rR7OmpN518h5U41JHiVZdABBoeYe0OgaJ2vAXCdSRvoJpKPSTeXr7Tsd6xpJcAA6
GwhyZ+LIHF3cbuNSwEvI9eHPWHErEiUMeIEynAzKVAWr1di66ECYU6tGk7HKXa7m
/fEdzLeasK0x2Vjw+62KjDXoilazJhcyrrRRO6mYxbXEsDYfBMwHdul0kUW8HQWD
eGt8p1h8VbbY7aH1OO/vqovLMi/+jl/fRaY2wV0rCtx+2UBVlx1N3DSQbtVbaWXm
fbjYbQY3oE836//dKmNsPHzuPbJ//8FvBN6/xXjDJQHR8DpLhQT/hmkEfx5Om0A=
=pdF+
-----END PGP SIGNATURE-----

Do not use the Infuser yet; it still has other issues, and items you put in may be lost.
Imprinter and infuser would previously not run their output until the output slot was clicked (likely, only in SSP).
Treealyzer and Beealyzer comment out a block of code (Flutterlyzer never had this in the first place) that was uncommented in these... doing the same here made the issue go away.
@mezz
Copy link
Member

mezz commented Apr 10, 2015

Looks good. CLAHub is very buggy.
Can you please update the PR by adding your name to this file? https://github.com/ForestryMC/ForestryMC/blob/dev/cla-signatures.txt
We're using it for anyone who can't sign on CLAHub. Thanks!

Also you should remove the bad lines rather than commenting them out.

@airbreather
Copy link
Contributor Author

257b779 deletes the code I commented out and the equivalent commented-out code that I followed for consistency.
5786a34 updates cla-signatures.txt.

@mezz
Copy link
Member

mezz commented Apr 11, 2015

Perfect! I'll merge this in tonight.

@mezz
Copy link
Member

mezz commented Apr 11, 2015

Added here: 0462e5a
Thanks again!

@mezz mezz closed this Apr 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants