Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround to allow other mods to get plank icons without position #971

Merged
merged 1 commit into from
Nov 18, 2015
Merged

Workaround to allow other mods to get plank icons without position #971

merged 1 commit into from
Nov 18, 2015

Conversation

buttilda
Copy link

I have a mod called WoodStuff that adds several wood blocks (like bookshelves, chests, buttons, etc) made out of other mod's planks.
It assumes that planks have their icons determined using solely metadata (I thought it would be okay to do it this way because so far I hadn't found any mod that used TileEntities).

This simple workaround would be enough to fix Forestry's support for WoodStuff, so I hope that's okay.

@CLAassistant
Copy link

CLA assistant check
All committers have accepted the CLA.

@buttilda
Copy link
Author

Pretty sure I signed that already...
Edit: Done it again anyway :3

@mezz
Copy link
Member

mezz commented Nov 18, 2015

Have you tried getting the icon from the Item?
IIcon getIconIndex(ItemStack stack) will return the correct icon.

@buttilda
Copy link
Author

I tried it and though it works for Forestry's planks, it doesn't work for other mods )=

This is what I currently do (in case you want to have a look):
https://github.com/ganymedes01/WoodStuff/blob/master/src/main/java/ganymedes01/woodstuff/blocks/BlockWoodPressurePlate.java

@mezz
Copy link
Member

mezz commented Nov 18, 2015

Ok well as long as you took a look. I don't see any possible negative effects from this PR

mezz added a commit that referenced this pull request Nov 18, 2015
Workaround to allow other mods to get plank icons without position
@mezz mezz merged commit a6ecc95 into ForestryMC:dev Nov 18, 2015
@buttilda
Copy link
Author

Yeah, I can't think of anything this change would break.

Thank you for merging it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants