Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastcraft and Fe don't get along together in same enviroment. #1351

Closed
Flukethoughts opened this issue Mar 15, 2015 · 14 comments
Closed

Fastcraft and Fe don't get along together in same enviroment. #1351

Flukethoughts opened this issue Mar 15, 2015 · 14 comments

Comments

@Flukethoughts
Copy link

FE 459
Fastcraft 1.19
Modpack magitechworld technic

@yuuka-miya
Copy link
Member

We patch things, they patch things too. You know the drill, we need logs.

@Flukethoughts
Copy link
Author

trust me if i could provide u a log with better information i would but the information it spits out is simplistic
Enjoy though
http://pastebin.com/EjNp1dY4

@yuuka-miya
Copy link
Member

Seems like their ASM is erroring out... pinging @sfPlayer1

@sfPlayer1
Copy link

Hmm interesting. What is ForgeEssentials editing in EntityPlayerMP? The error means that the fc injector found 3 location matches instead of the expected 1.

I also need the CLASSLOADER_TEMP/net/minecraft/entity/player/EntityPlayerMP.class from the same setup without FastCraft installed. The server needs the additional parameters -Dlegacy.debugClassLoading=true -Dlegacy.debugClassLoadingSave=true to generate said file. Don't forget to disable it again afterwards.

@FiveEYZ
Copy link

FiveEYZ commented Mar 16, 2015

im generating same error on my FTB Infinity server, here is the file you are requesting. https://drive.google.com/open?id=0B47wGOooeWGIV0pQZTZoQkxmZDA&authuser=0

@sfPlayer1
Copy link

The file isn't publicly accessible.

@FiveEYZ
Copy link

FiveEYZ commented Mar 16, 2015

should be public now

@sfPlayer1
Copy link

The real issue is in the mixin library ForgeEssentials pulls in.

There's an extra transformer invocation in:
at org.spongepowered.asm.mixin.transformer.TreeInfo.applyTransformers(TreeInfo.java:147)

Apparently it also causes LaunchClassLoader to drop the class, loading it again later, which whould be the 3rd invocation Fastcraft counted.

That's invalid since the class loader prevents multiple invocations. Doing so regardless imposes extra requirements on the IClassTransformer implementations, which aren't necessarily met.

@micmou
Copy link

micmou commented Mar 25, 2015

Same bug experienced on custom RR Server log is below no crash report
http://pastebin.com/TmjPBnSZ

@sfPlayer1
Copy link

You can potentially work around it by specifying the extra java parameter -Dfastcraft.asm.permissive (before -jar).

@micmou
Copy link

micmou commented Mar 25, 2015

Seems to be working so far thanks I imagine it is pretty dirty to bypass it

@P3rf3ctXZer0
Copy link

Confirmed fix :D I don't know what you mean by dirty but I am not losing any frames for the bypass :D

@FiveEYZ
Copy link

FiveEYZ commented Mar 25, 2015

think he meant "dirty to bypass it" because its a server issue and not client.

@P3rf3ctXZer0
Copy link

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants