-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12.0][MIG] change_management #155
Conversation
b7b8724
to
01981df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
18d89f8
to
d45f906
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not working:
-
Go to a project and then click on Changes button.
Uncaught Error: NameError: name 'uid' is not defined
-
Create a change from the change menu. Try to confirm it. I get:
TypeError: 2019-10-22 10:11:22 (field change.management.change.date_confirmed) must be string or date, not datetime.
Almost there keep going :)
d45f906
to
e01492f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AttributeError: type object 'Date' has no attribute 'now'
when confirming a change order
also the button form the project also fails, the same error commented.
👎
10ba272
to
900a788
Compare
900a788
to
6e4fa73
Compare
6e4fa73
to
8c40de0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional LGTM
8c40de0
to
504d1d5
Compare
504d1d5
to
8740709
Compare
Codecov Report
@@ Coverage Diff @@
## 12.0 #155 +/- ##
==========================================
- Coverage 69.52% 67.67% -1.86%
==========================================
Files 62 64 +2
Lines 1739 1924 +185
==========================================
+ Hits 1209 1302 +93
- Misses 530 622 +92
Continue to review full report at Codecov.
|
Standard migration.