Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][MIG] change_management #155

Merged
merged 12 commits into from
Oct 22, 2019
Merged

Conversation

MiquelRForgeFlow
Copy link

Standard migration.

Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lack_green

@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 12.0-mig-change_management branch 5 times, most recently from 18d89f8 to d45f906 Compare October 21, 2019 16:43
@MiquelRForgeFlow
Copy link
Author

green

Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not working:

  • Go to a project and then click on Changes button.
    Uncaught Error: NameError: name 'uid' is not defined

  • Create a change from the change menu. Try to confirm it. I get:
    TypeError: 2019-10-22 10:11:22 (field change.management.change.date_confirmed) must be string or date, not datetime.

Almost there keep going :)

Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AttributeError: type object 'Date' has no attribute 'now'

when confirming a change order

also the button form the project also fails, the same error commented.

👎

Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional LGTM

@codecov-io
Copy link

Codecov Report

Merging #155 into 12.0 will decrease coverage by 1.85%.
The diff coverage is 50.8%.

Impacted file tree graph

@@            Coverage Diff             @@
##             12.0     #155      +/-   ##
==========================================
- Coverage   69.52%   67.67%   -1.86%     
==========================================
  Files          62       64       +2     
  Lines        1739     1924     +185     
==========================================
+ Hits         1209     1302      +93     
- Misses        530      622      +92
Impacted Files Coverage Δ
purchase_request_sale/models/stock_rule.py 100% <ø> (ø) ⬆️
analytic_plan/models/product.py 100% <ø> (ø) ⬆️
analytic_plan/models/project.py 100% <100%> (ø) ⬆️
change_management/models/change_management.py 48.57% <48.57%> (ø)
change_management/models/project_task.py 81.81% <81.81%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0b0ff8...8740709. Read the comment docs.

@MiquelRForgeFlow
Copy link
Author

i-am-ready

@AaronHForgeFlow AaronHForgeFlow merged commit 8f0205f into 12.0 Oct 22, 2019
@AaronHForgeFlow AaronHForgeFlow deleted the 12.0-mig-change_management branch October 22, 2019 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants