Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mumble Icon #352

Merged
merged 2 commits into from
Sep 4, 2021
Merged

Add Mumble Icon #352

merged 2 commits into from
Sep 4, 2021

Conversation

mrdrogdrog
Copy link
Contributor

@mrdrogdrog mrdrogdrog commented Sep 4, 2021

This PR adds the icon of Mumble

Fixes #278

@shinenelson
Copy link
Member

I will let you fix that merge conflict while I build the icon locally to see how it looks.

PS : You cannot fix your own pull request, I think you intended to link #278.

But good going anyway 👍

@mrdrogdrog
Copy link
Contributor Author

Fixed it. I also resized the icon. You should pull again.

Signed-off-by: Tilman Vatteroth <git@tilmanvatteroth.de>
Copy link
Member

@shinenelson shinenelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while this looks okay

image

I think we could avoid the circle around the logo unless there are strict brand guidelines around it.

@mrdrogdrog
Copy link
Contributor Author

I'm not sure.. It's always used with that circle.

@shinenelson
Copy link
Member

From a brand perspective, sure, but I am thinking about the various use-cases where this icon might be used. It can be used on project pages where they list their social media accounts. And when all other icons do not have an enclosure, it would be odd if this logo is used with the enclosure.

And besides, one can stack a fa-circle, fa-square or whatever other icon that is available in the set to re-create their desired output with fork-awesome.

@mrdrogdrog
Copy link
Contributor Author

I removed the circle

Copy link
Member

@shinenelson shinenelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks much better

image

@shinenelson shinenelson merged commit 792a1c7 into ForkAwesome:master Sep 4, 2021
@mrdrogdrog mrdrogdrog deleted the mumble branch September 4, 2021 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon Request: fa-mumble
2 participants