-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Mumble Icon #352
Add Mumble Icon #352
Conversation
I will let you fix that merge conflict while I build the icon locally to see how it looks. PS : You cannot fix your own pull request, I think you intended to link #278. But good going anyway 👍 |
Fixed it. I also resized the icon. You should pull again. |
Signed-off-by: Tilman Vatteroth <git@tilmanvatteroth.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure.. It's always used with that circle. |
From a brand perspective, sure, but I am thinking about the various use-cases where this icon might be used. It can be used on project pages where they list their social media accounts. And when all other icons do not have an enclosure, it would be odd if this logo is used with the enclosure. And besides, one can stack a |
I removed the circle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR adds the icon of Mumble
Fixes #278