Tools refactoring #24
Conversation
init.py
Outdated
| ) as out_file: | ||
| for triple in graph: | ||
| out_file.write('%s %s %s \n' % (triple[0], triple[1], triple[2])) | ||
| #!/usr/bin/python3 |
There was a problem hiding this comment.
Seems, that script is not only for initialization from now. Should it be renamed?
There was a problem hiding this comment.
Yes, I wanted to rename it, but I didn't come up with anything. Can you suggest a better name?
src/utils/filters.py
Outdated
| return extensions is None or any([file.endswith(ext) for ext in extensions]) | ||
|
|
||
|
|
||
| def file_has_size(file, left_bound=None, right_bound=None): |
There was a problem hiding this comment.
Why file size, not stored graph size?
There was a problem hiding this comment.
I think there should be both options. There are problems with the size of graphs. Exactly to compute it for rdf files at first we need to parse this files. This takes a long time. So maybe the graph size should be approximated by the number of lines in the file?
There was a problem hiding this comment.
Well. We plan to add metadata for graphs (number of vertices and edges). So, can we use this data here?
There was a problem hiding this comment.
Yes, of course. I can add additional flags and corresponding filters when the metadata appears.
…Data into tools_refactoring
Tools refactoring refactoring
I think all tools should be part of the same python script. So in terms of
argparsewe can use subparsers. Something like this:python3 init tool_1 [tool_1 args],python3 init tool_2 [tool_2 args]and so on. This will cause CFPQ_Data to be formed as a single package.