Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Wait processing before auto-starting job #46

Closed
Daniel4182 opened this issue Oct 27, 2020 · 3 comments
Closed

[Feature Request] Wait processing before auto-starting job #46

Daniel4182 opened this issue Oct 27, 2020 · 3 comments
Labels
Enhancement Implemented This enhancement has been implemented and committed (first to devel).

Comments

@Daniel4182
Copy link

Daniel4182 commented Oct 27, 2020

Hello devs,

In Super slicer i usually, export direct to the octopi and set it to start printing, but arch welder will start processing the code and octopi start with the non processed version as i can tell, i think that maybe i got a print failure because of it, can not prove it tough, if it's not a problem, i would like it to see octoprint waiting for the processed code, before the print start

@FormerLurker
Copy link
Owner

For the time being, please disable automatic processing in arcwelder. Since arc welder will not start a job while printing, I suspect that ot started processing first, then the print started. The only solutions I can think of are spawning a thread in C++ to do the processing (technically difficult) or cancelling preprocessing if a print starts during processing. I will think about it

@FormerLurker FormerLurker added the Enhancement New feature or request label Oct 27, 2020
@FormerLurker FormerLurker added Enhancement Implemented This enhancement has been implemented and committed (first to devel). and removed Enhancement New feature or request labels Oct 28, 2020
@FormerLurker
Copy link
Owner

Hey @Daniel4182 , this fix has been implemented. If you want to test it, you can install from this url within the plugin manager (get more->From Url...): https://github.com/FormerLurker/ArcWelderPlugin/archive/1.0.1.rc1.dev1.zip. Please read the release notes here. You can comment in this thread and if there are problems I may ask you to create a new issue. Thanks!

@o-nix
Copy link

o-nix commented Dec 6, 2020

As I came to GitHub issues specifically for this feature request I should say GREAT JOB @FormerLurker!
I became a patron and everybody should! @Daniel4182

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Implemented This enhancement has been implemented and committed (first to devel).
Projects
None yet
Development

No branches or pull requests

3 participants