This repository has been archived by the owner on Apr 2, 2021. It is now read-only.
Use a web-friendly URL in post-deploy message #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub appears to try and parse the "@" username included in the message, and hides everything past the "@" symbol entirely (potentially because my expo account username and github username is the same?). Expo does provide a hosted web link that can be linked to instead - which is probably more helpful then the `expo://` url anyways (since it's tappable and includes instructions for downloading expo, etc).
tonyxiao
added a commit
to beamf/appr
that referenced
this pull request
Dec 3, 2017
Merge remote-tracking branch 'conrad-vanl/patch-1' FormidableLabs#10
|
This is great! Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub appears to try and parse the "@" username included in the message, and hides everything past the "@" symbol entirely (potentially because my expo account username and github username are the same?):
Expo does provide a hosted web link that can be linked to instead - which is probably more helpful then the
expo://url anyways (since it's tappable and includes instructions for downloading expo, etc):