Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vulnerabilities found via npm audit #52

Merged
merged 1 commit into from
Jan 2, 2019

Conversation

GaxZE
Copy link
Contributor

@GaxZE GaxZE commented Oct 16, 2018

Issue

Found the following when running npm install

added 504 packages from 282 contributors, updated 11 packages and audited 4150 packages in 10.457s
found 189 vulnerabilities (188 low, 1 critical)
  run `npm audit fix` to fix them, or `npm audit` for details

What I've done

I've updated package.json to secure the packages.

How to test

run npm test

  babel-plugin-transform-define
    transformation tests
      ✓ should transform Unary Expressions
      ✓ should transform Identifiers
      ✓ should transform false
      ✓ should transform 0
      ✓ should transform empty string
      ✓ should transform null
      ✓ should transform undefined
      ✓ should transform code from config in a file
      Member Expressions
        ✓ should transform with config defined by String keys
        ✓ should transform with config defined by an Object
    unit tests
      getSortedObjectPaths
        ✓ should return an array
        ✓ should return a complete list of paths
        ✓ should return a list sorted by length


  13 passing (253ms)

Result

npm audit

                       === npm audit security report ===

found 0 vulnerabilities
 in 4143 scanned packages

@GaxZE
Copy link
Contributor Author

GaxZE commented Oct 23, 2018

@boygirl as you closed #51 can you take a look at this?

@simonstaton
Copy link

Possible to get this merged in? This package is now failing npm audits due to lodash

@MelleB MelleB mentioned this pull request Dec 5, 2018
@pdf13
Copy link

pdf13 commented Dec 5, 2018

Let's get this merged! 🚀

@HofmannZ
Copy link

LGTM

@lvnilesh
Copy link

Appreciate if you can please merge. Thanks.

@GaxZE
Copy link
Contributor Author

GaxZE commented Dec 31, 2018

New years resolution?!

@boygirl
Copy link
Contributor

boygirl commented Jan 2, 2019

Sorry for the delay!

@boygirl boygirl merged commit 7cd228e into FormidableLabs:master Jan 2, 2019
@boygirl boygirl mentioned this pull request Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants