This repository has been archived by the owner on Mar 4, 2022. It is now read-only.
Configurable log levels for builder itself. #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-roemer
force-pushed
the
chore-log-levels
branch
2 times, most recently
from
35a127f
to
d2c0ed6
Compare
| @@ -14,6 +14,7 @@ var log = require("../lib/log"); | |||
| * @param {Object} [opts] Options object | |||
| * @param {Object} [opts.env] Environment object to mutate (Default `process.env`) | |||
| * @param {Array} [opts.argv] Arguments array (Default: `process.argv`) | |||
| * @param {Array} [opts.msgs] Array of log messages. | |||
There was a problem hiding this comment.
Am I correct in understanding that these are not log messages but message templates?
There was a problem hiding this comment.
Array of { level, type, msg }. I'll update the comment.
|
Looks goo! One small code change and a few style comments but otherwise 👍 |
|
Assuming it works, looks good to me! @baer? |
| @@ -14,6 +14,7 @@ var log = require("../lib/log"); | |||
| * @param {Object} [opts] Options object | |||
| * @param {Object} [opts.env] Environment object to mutate (Default `process.env`) | |||
| * @param {Array} [opts.argv] Arguments array (Default: `process.argv`) | |||
| * @param {Array} [opts.msgs] Array of log messages (`{ level, type, msg }`) | |||
There was a problem hiding this comment.
This might be more clear as "message-templates" or something since these are not JUST messages but that's just a personal preference
|
A few style things but other than that this is airtight. 👍 |
* Refactor `builder.js` to pass a buffer of messages to builder to be later logged. * Refactor to queue up log statements until `log.setLevel()` is called. The issue we're solving is logging in "./environment" when environment is needed to determine what level to log at. * Adds `--log-level=info|warn|error|none` flag. Fixes #6 * Adds `--quiet` flag as alias for `--log-level=none`. * Adds env variable `_BUILDER_ARGS_LOG_LEVEL=info|warn|error|none` to also control. * Add tests and docs.
ryan-roemer
force-pushed
the
chore-log-levels
branch
from
6e9b658
to
2a7ec90
Compare
ryan-roemer
added a commit
that referenced
this pull request
Mar 9, 2016
Configurable log levels for builder itself.
|
Posthumous 👍 – nice work ;) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
builder.jsto pass a buffer of messages to builder to belater logged.
log.setLevel()is called. Theissue we're solving is logging in "./environment" when environment is
needed to determine what level to log at.
--log-level=info|warn|error|noneflag. Fixes Feature: Configurable log levels. #6--quietflag as alias for--log-level=none._BUILDER_ARGS_LOG_LEVEL=info|warn|error|noneto alsocontrol.
These new controls should allow us to easily set things for test commands. Closes #66
Note: I'm not totally sure this won't break in earlier
builderglobal installs. We may need to educate folks generally to update if we see any errors forsetLevel()not being defined / a function./cc @chaseadamsio @shakefon @zachhale @coopy