This repository has been archived by the owner on Mar 4, 2022. It is now read-only.
Document "the module pattern" for using prod/dep archetype dependencies. #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| lib-name@right-version | ||
| ``` | ||
|
|
||
| This unfortunately mean that the search path for `require("lib-name")` is: |
|
A couple minor typos, but your explanation of the module pattern makes sense to me. |
| archetype dependencies. | ||
| Node.js files in the normal production archetype do not need a | ||
| `<archetype>/require.js` file akin to the dev archetype because | ||
| `<archetype>/node_modules` is already at top of the require search path. |
|
A couple of minor comments; LGTM! |
ryan-roemer
added a commit
to FormidableLabs/builder-victory-component
that referenced
this pull request
Apr 4, 2016
* Sister PR to Builder documentation PR at FormidableLabs/builder#110 * Switches to "the module pattern" for all dev dependencies. * Provides a require for prod archetype as well. * Harmonizes travis config with other repos (and does npm2 and npm3 installs for each node) * Harmonizes config/webpack/docs/webpack.config.hot.js with config/webpack/demo/webpack.config.hot.js
ryan-roemer
added a commit
to FormidableLabs/builder-victory-component
that referenced
this pull request
Apr 4, 2016
* Sister PR to Builder documentation PR at FormidableLabs/builder#110 * Switches to "the module pattern" for all dev dependencies. * Provides a require for prod archetype as well. * Harmonizes travis config with other repos (and does npm2 and npm3 installs for each node) * Harmonizes config/webpack/docs/webpack.config.hot.js with config/webpack/demo/webpack.config.hot.js
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes BUG:
require()looks to project root _first_ irrespective ofNODE_PATH. #107builderto make archetype application dependencies available to upstream components #83/cc @coopy @boygirl @chaseadamsio @shakefon @exogen @baer