Skip to content
This repository has been archived by the owner on Mar 4, 2022. It is now read-only.

[MAJOR] Feature: pre/post lifecycle #156

Merged
merged 87 commits into from Feb 23, 2018
Merged

Conversation

ryan-roemer
Copy link
Member

@ryan-roemer ryan-roemer commented Feb 13, 2018

  • Breaking: Add pre|post lifecycle commands
  • Breaking: Error out on invalid or conflicting command line flags passed
  • Clean up --setup execution and constraints. Add more tests.
  • Add cross-os functional tests.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.6%) to 94.257% when pulling 6d71ff0 on feature/pre-post-lifecycle into 390eaa4 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.6%) to 94.257% when pulling 6d71ff0 on feature/pre-post-lifecycle into 390eaa4 on master.

@ryan-roemer
Copy link
Member Author

Travis and Appveyor seem to be out of git sync with errors like:

 1) bin/builder-core builder run runs a <root>/package.json command:
     Error: Cannot find module './utils/setup'
      at Task.setup (lib/task.js:1:40475)
      at async.series._.extend.tracker (lib/task.js:1:43649)
      at node_modules/async/lib/async.js:718:13
      at iterate (node_modules/async/lib/async.js:262:13)
      at async.forEachOfSeries.async.eachOfSeries (node_modules/async/lib/async.js:281:9)
      at _parallel (node_modules/async/lib/async.js:717:9)
      at Object.async.series (node_modules/async/lib/async.js:739:9)
      at Task.run (lib/task.js:1:43446)
      at Function.invoke (node_modules/sinon/lib/sinon/spy.js:176:59)
      at proxy [as run] (eval at createProxy (node_modules/sinon/lib/sinon/spy.js:81:86), <anonymous>:1:35)
      at Task.execute (lib/task.js:1:51355)
      at module.exports (bin/builder-core.js:1:4717)
      at Context.<anonymous> (test/server/spec/bin/builder-core.spec.js:401:7)

closing and re-opening to hopefully kick. (Just a wild stab in the dark)

@ryan-roemer ryan-roemer reopened this Feb 19, 2018
@ryan-roemer ryan-roemer changed the title WIP: Feature/pre post lifecycle Feature/pre post lifecycle Feb 23, 2018
@ryan-roemer ryan-roemer changed the title Feature/pre post lifecycle [MAJOR] Feature: pre/post lifecycle Feb 23, 2018
@ryan-roemer
Copy link
Member Author

@jstrimpel -- At long last, builder pre|post is all ready to go! I've refactor the entire execution model and improved that along the way too (particularly with handling errors / early exits when things go wrong).

Let me know how it looks on your end. From here, I'm going to do three short additional changes before releasing a new MAJOR:

  • Add a debug log level.
  • Default to --quiet=true for toning down all the builder.
  • Add an engines restriction to node4+ (I won't refactor the code to node4+ now, just want to get the breaking change out of the way)

@ryan-roemer ryan-roemer merged commit 2a3d229 into master Feb 23, 2018
@ryan-roemer ryan-roemer deleted the feature/pre-post-lifecycle branch February 23, 2018 20:52
@ryan-roemer
Copy link
Member Author

Released in builder@4.0.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants