This repository has been archived by the owner on Mar 4, 2022. It is now read-only.
BUG: Fix PATH/NODE_PATH resolution order. #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… args run flags.
| @@ -142,7 +142,7 @@ Task.prototype.run = function (callback) { | |||
|
|
|||
| var env = this._env.env; // Raw environment object. | |||
| var task = this.getCommand(this._command); | |||
| var flags = args.concurrent(this.argv); | |||
| var flags = args.run(this.argv); | |||
|
Just checked out this branch and it does indeed fix the error I was seeing. Running |
ryan-roemer
added a commit
that referenced
this pull request
Dec 9, 2015
BUG: Fix PATH/NODE_PATH resolution order.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47
We now have a more sensible PATH / NODE_PATH resolution order.
Also:
builder run/cc @dandelany @boygirl @exogen @chaseadamsio
@dandelany @boygirl @exogen -- Can one of you try this out in an erroring Victory repo? Thanks!