This repository has been archived by the owner on Feb 17, 2022. It is now read-only.
Move prop-types to peerDependencies #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If no one else knows existing online JS repls, then we can just ship this and fix things online later... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
prop-typestopeerDependencies(anddevDependenciesso they're available during development/testing/etc.) Fixes #113.Bonus: Update
React.PropTypesreferences in the docs.Down the line this should be included in a major release since it will break consumers who don't already have
prop-typesinstalled.@ryan-roemer @kenwheeler Do you know if we have any CodePen/JSBin/etc. type pages demoing Component Playground that will need to be updated to include
prop-types?