Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Body scroll disabled #913

Closed
chocovelod opened this issue Jun 21, 2022 · 8 comments
Closed

Body scroll disabled #913

chocovelod opened this issue Jun 21, 2022 · 8 comments

Comments

@chocovelod
Copy link

Hey!
The body does not scroll vertically on the carousel, how can this be fixed?

@ValGeorgiev
Copy link
Contributor

Hey @chocovelod, could you give more information, what you mean about body doesn't scroll vertically? Screenshot and code sandbox it will be useful

@chocovelod
Copy link
Author

Снимок экрана 2022-06-21 в 10 41 56

I cant scroll page when my finger on carousel container. Only carousel items swiping.

@Rawphs
Copy link

Rawphs commented Jun 21, 2022

Hey, I was about to make an issue about this. I've made a small sandbox to exemplify the problem, I am assuming we have the same issue. https://codesandbox.io/s/condescending-rgb-3w5stf?file=/src/App.js

If dragging is false and swiping is true, the carousel does not slide on swipe for mobile. If both are true and the carousel occupies a significant space on the mobile screen (as it is often the case) we cannot scroll down the page anymore.

EDIT: this only happens on v5, I was previously using v4.8.3 and it was working fine. I did check all breaking changes but is there something I missed?

@ValGeorgiev
Copy link
Contributor

I was able to reproduce it on real device, I will have a look. Thanks for letting us know

@chocovelod
Copy link
Author

Im using 5.0.16v and it doest help

@ValGeorgiev
Copy link
Contributor

FYI: this was disabled because of this issue. #874 . I am looking for a fix, that will make everyone happy :)

@chocovelod
Copy link
Author

I think it's nice to have some property that can change overflow-y to "auto". Might be helpful

@fritz-c
Copy link
Contributor

fritz-c commented Aug 18, 2022

As of 5.2.0, this has been fixed. You can test here to see:
https://codesandbox.io/s/blazing-moon-duy07s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants