Fix screen measurement when scrollWidth is a float #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 16cd0dd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sarmeyer
approved these changes
Apr 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix screen measurement when scrollWidth is a float
The scrollWidth of a container is a rounded float value that causes the measurement to incorrectly round up when using
Math.ceilif the container's actual size is +/- some small value.This uses
Math.roundfor the page calculation when usingscreento avoid this problem and adds test coverage for theuseMeasurementhook.Actual Code fix: https://github.com/FormidableLabs/nuka-carousel/pull/1055/files#diff-d7aa6b5d278c998ec50a4b1441434b2e91b6a23af75fcd2ab8ddec4fff44aa14L30