Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disableEdgeSwiping prop #551

Merged
merged 3 commits into from May 24, 2019
Merged

Conversation

maurispalletti
Copy link

Description

Added prop to disable edge swiping, in order to block the white space that appears when swiping before first slide and after last slide. When reaching edges, there is no animation that allows going after that slide.

It is false by default, and only works when wrapAround is disabled.

Fixes #542

Type of Change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

I have run yarn run check and yarn run test-e2e and tests pass.

Checklist:

  • My code follows the style guidelines of this project (I have run yarn lint)
  • New and existing unit tests pass locally with my changes (I have run yarn test and yarn test-e2e)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • For any breaking API changes, I have updated the type definitions in index.d.ts
  • My changes generate no new warnings

Copy link
Member

@sarmeyer sarmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great - this is a neat prop feature!

@sarmeyer sarmeyer merged commit fea6324 into FormidableLabs:master May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable scroll before first slide and after last slide
2 participants