Fix onDragStart to happen only when dragging/swiping #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jflayhart
commented
Sep 8, 2019
| @@ -279,6 +275,11 @@ export default class Carousel extends React.Component { | |||
| ) | |||
| ); | |||
|
|
|||
| if (length >= 10) { | |||
| if (this.clickDisabled === false) this.props.onDragStart(e); | |||
| this.clickDisabled = true; | |||
There was a problem hiding this comment.
Probably should have disabled click here anyway, which prevents unwanted click events from firing during swiping on touch devices!
jflayhart
commented
Sep 8, 2019
| @@ -1181,6 +1181,7 @@ Carousel.defaultProps = { | |||
| framePadding: '0px', | |||
| height: 'auto', | |||
| heightMode: 'max', | |||
| onDragStart() {}, | |||
There was a problem hiding this comment.
Added default prop to avoid guards everywhere of if (this.props.onDragStart) ...
jflayhart
commented
Sep 8, 2019
| if (length >= 10) this.clickDisabled = true; | ||
| if (length >= 10) { | ||
| if (this.clickDisabled === false) this.props.onDragStart(e); | ||
| this.clickDisabled = true; |
There was a problem hiding this comment.
@sarmeyer I don't love coupling these two together (disable click + drag start), but it works and somewhat related. Any better ideas?
There was a problem hiding this comment.
I can't think of anything right now, we can leave this in until I (or someone else with time) has time to figure out another solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is this new prop
onDragStartthat happensonClickoronTouchrather than an actual drag/swipe event. I modified the code slightly to make the behavior more appropriate to the event. It is better to do it this way so the event doesn't give a false impression that it is starting a drag event when only a click occurs.Fixes #579
Type of Change
How Has This Been Tested?
Using the demo and writing a unit test.
Desktop
Mobile