Avoid redundant dimension calculations after a DOM mutation #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed the callback logic of a MutationObserver to avoid repeatedly calling a function that needs to be called once. Helps a lot with performance issues reported in #617.
Fixes #617
Type of Change
How Has This Been Tested?
I stress tested this change in a proprietary codebase where I use nuka-carousel. I am not able to share that code at the moment. To test the change, one should fill a carousel with complex object architectures where re-renders and image loads are likely to occur.
Checklist: (Feel free to delete this section upon completion)