Add typing to support changes introduced in #644 #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frnk94
force-pushed
the
add-typing-to-new-props
branch
from
a0b4f74
to
66d14b5
Compare
frnk94
force-pushed
the
add-typing-to-new-props
branch
2 times, most recently
from
31bb8ea
to
8dd984a
Compare
|
This seems pretty legit. Can we get a review on this? +(>9000) |
frnk94
force-pushed
the
add-typing-to-new-props
branch
from
8dd984a
to
3bf07cc
Compare
sarmeyer
approved these changes
Feb 6, 2020
|
@frnk94 Thank you for submitting this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#644 Introduced new props but didn't add typing to support those.
This PR also add
getControlsContainerStyles&defaultControlsConfig .containerClassNameto target the container wrapping controls