Feature 637: Added scrollMode prop #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariano-formidable
force-pushed
the
feature/scroll-mode
branch
from
2cb2db1
to
25d5a65
Compare
mariano-formidable
changed the title
mariano-formidable
changed the title
|
I think we just need to define a type for ScrollMode in index.d.ts - otherwise looks good to me |
Ohhhhhh yeah, I forgot nuka now has internal types. I'll update the type file and let you know when you can re-review. |
mariano-formidable
force-pushed
the
feature/scroll-mode
branch
from
25d5a65
to
6bc6ef8
Compare
| * Supports 'page' and 'remainder' scroll modes. | ||
| * Defaults to 'remainder'. | ||
| */ | ||
| scrollMode?: CarouselScrollModeProp; |
There was a problem hiding this comment.
Updated the type defs 👍
sarmeyer
approved these changes
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
scrollModeprop tonuka. When it's set topage, nuka will setslidesToScrollequal toslidesToShowand page through each slide which can result in blank slides at the end. However, ifscrollModeis set toremainder, thennukawill behave at it normally does.Fixes #637
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Manually tested, and all the CI tests pass.
Screenshots
Scroll mode set to
remainder,slidesToShow=2,slidesToScroll=1:Scroll mode set to
page,slidesToShow=2, nuka ignores the prop `slidesToShow':