Fix normalizeTokens overriding "plain" cascading types #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the assumption was made that nested "plain" string tokens inside other typed tokens should still *only* be of type "plain". Instead they should cascade their styles. So when the nested types array is: ["tag", "punctuation"], and we encounter a plain string, the output type should be the same types array.
|
Reviewed in person by @sofiapoh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9
Previously the assumption was made that nested "plain"
string tokens inside other typed tokens should still
only be of type "plain". Instead they should cascade
their styles.
So when the nested types array is: ["tag", "punctuation"],
and we encounter a plain string, the output type should be
the same types array.