Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2 with updated API #191

Merged
merged 5 commits into from Apr 22, 2023
Merged

Release v2 with updated API #191

merged 5 commits into from Apr 22, 2023

Conversation

carloskelly13
Copy link
Contributor

@@ -121,6 +122,18 @@ ReactDOM.createRoot(document.getElementById("root") as HTMLElement)

```

### Custom Language Support
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @ryan-roemer I took your suggestion to bring this section to the forefront and verified the methods worked via our demo app

// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
await import("prismjs/components/prism-applescript")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👇🏻 example of AppleScript highlighting. As a note TypeScript doesn't love importing languages from prismjs/components so we need to @ts-ignore it, despite the exports existing.

Screenshot 2023-04-21 at 8 07 37 AM

Copy link
Member

@ryan-roemer ryan-roemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!!!

Copy link
Contributor

@gksander gksander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, one minor suggestion on the documentation

README.md Outdated Show resolved Hide resolved
@carloskelly13 carloskelly13 merged commit 6097385 into master Apr 22, 2023
3 checks passed
@carloskelly13 carloskelly13 deleted the v2-release branch April 22, 2023 00:44
@github-actions github-actions bot mentioned this pull request Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants