feat: Add One Light and One Dark Themes #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mrousavy – thanks for contributing this. As an avid OneDark user, I really appreciate this 😄 I pulled down your branch and integrated the new themes into the demo, but most tokens seem to be getting colored with the
|
|
Added a few tweaks to oneDark and oneLight:
And added a changeset record so we can release this into the wild once merged. |
carloskelly13
approved these changes
Sep 26, 2023
Merged
|
Okay, these changes should be live with version 2.1.0 🥳 |
|
Ah yeah I think I messed something up with the colors, my fault!! I'll try with your changes in a second to double check if both themes look correct, orherwise I'll send another PR! Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #218